Miscellaneous small answer changes by ekluzek · Pull Request #1497 · ESCOMP/CTSM

ekluzek · 2021-09-23T07:17:01Z

Description of changes

Change ceta from 450 to 358 for CTSM5.1
Turn Medlyn on for PHS off for clm51 and clm50 (3 dynroot tests will change answers)
Make max CO2 partial pressure consistent
Change surface datasets to only use 78PFT versions (so SP results may change) [except for FATES and vichydro]
Fix GSSUN and GSSHA history variables so now not just missing values
Changes FATES to run with use_nitrif_dentrif=T by defaul;t
Change dynlakes test to methane/use_nitrif_=T
(This will allow use_nitrif and methane flags to be removed)

Specific notes

Contributors other than yourself, if any: @djk2120

CTSM Issues Fixed (include github issue #):
Fixes #1504
Fixes #1503
Fixes #1462
Fixes #1394
Fixes #1460
Fixes #1465
Worked on #1356
Fixes #1496

Are answers expected to change (and if so in what way)? Yes!
Small changes to a few defaults will change answers in most configurations

Any User Interface Changes (namelist or namelist defaults changes)? Changes some defaults

Testing performed, if any: Limited so far, will do regular testing
testing passes as expected on cheyenne

…files with values not just identical to missing value

…xing ESCOMP#1394

…272 to avoid deep soil caron in permafrost regions fixing ESCOMP#1460

…oil_decomp_method is None, and otherwise TRUE which means it will normally be true when FATES is on fixing ESCOMP#1465

…COMP#43, we currently just allow it to be true even through the conservation check for methane fails at the first time step of each year

…less if PHS is on or off

…arch for an exact match, this allows non irrigated to always be an option so the test for it can be removed

…ing first for nofail with crop and irrigation true, and if didn't find it try again with the exact match

… SP datasets, while setting it to false for the crop datasets for landuse timeseries

ekluzek · 2021-09-30T05:53:26Z

I've fixed #1503 and #1504. Need to do some study in order to get #1505 to work for the FATES cases.

…ther

…ATES don't check for crop datasets first, add non vichydro datasets (pointing to the same file) for fsurdat and flanduse_timeseries so that FATES can use those datasets

ekluzek · 2021-10-06T18:32:24Z

This is now passing all tests as expected on cheyenne. izumi seems to be down, so will test as soon as I can.

ekluzek · 2021-10-07T18:31:05Z

izumi is back up, and all tests are now passing on izumi. So this is ready to come in. Just need to do the ChangeLog file.

ekluzek · 2021-10-08T02:38:21Z

Some some clm4_5 and clm5_0 tests remain identical. The VIC tests are identical which is expected. Urban single point tests are identical, which seems reasonable. PTSMODE tests are identical, that's expected. NoAnthro test because it doesn't change. There are a few other tests that are identical mostly with Crop as that means it won't change the dataset, and mostly not cold-starts, and mostly short enough.

ERP_Ld3.f09_g17.I1850Clm50BgcCropCru.cheyenne_intel.clm-ciso
ERS_Ld3.f09_g17.I1850Clm50BgcCrop.cheyenne_intel.clm-rad_hrly_light_res_half
ERS_Lm40_Mmpi-serial.1x1_numaIA.I2000Clm50BgcCropQianRs.cheyenne_gnu.clm-monthly <<< 40 month
ERS_Lm54_Mmpi-serial.1x1_numaIA.I2000Clm50BgcCropQianRs.cheyenne_intel.clm-cropMonthOutput <<< 54 month
ERS_Ly20_Mmpi-serial.1x1_numaIA.I2000Clm50BgcCropQianRs.cheyenne_intel.clm-cropMonthOutput. <<<< 20 years
ERS_Ly3_Mmpi-serial.1x1_smallvilleIA.IHistClm50BgcCropQianRs.cheyenne_gnu.clm-cropMonthOutput <<<< 3 years
ERS_Ly5_Mmpi-serial.1x1_smallvilleIA.I2000Clm50BgcCropQianRs.cheyenne_gnu.clm-ciso_monthly <<<<< 5 years
ERS_Ly6_Mmpi-serial.1x1_smallvilleIA.IHistClm50BgcCropQianRs.cheyenne_intel.clm-cropMonthOutput <<<< 6 years
LII2FINIDATAREAS_D_P360x2_Ld1.f09_g17.I1850Clm50BgcCrop.cheyenne_intel.clm-default
LII_D_Ld3.f19_g17.I2000Clm50BgcCrop.cheyenne_intel.clm-default
PFS_Ld20.f09_g17.I2000Clm50BgcCrop.cheyenne_intel
SMS_D_Lm1_Mmpi-serial.CLM_USRDAT.I1PtClm50SpRs.cheyenne_intel.clm-USUMB_mct
SMS_D_Lm1_Mmpi-serial_Vnuopc.CLM_USRDAT.I1PtClm50SpRs.cheyenne_intel.clm-USUMB_nuopc
SMS_Ld2_D.f09_g17.I1850Clm50BgcCropCmip6.cheyenne_intel.clm-basic_interp
SOILSTRUCTUD_Ld5.f10_f10_mg37.I2000Clm50BgcCrop.cheyenne_intel.clm-default

Cold starts I'm a bit surprised at being identical...

ERS_Lm20_Mmpi-serial.1x1_smallvilleIA.I2000Clm50BgcCropQianRs.cheyenne_gnu.clm-monthly_noinitial <<< 20 month
SMS_D_Ld9.f09_g17.I1850Clm50BgcNoAnthro.cheyenne_intel.clm-decStart1851_noinitial
SMS_Ly3_Mmpi-serial.1x1_numaIA.I2000Clm50BgcDvCropQianRs.cheyenne_gnu.clm-ignor_warn_cropMonthOutputColdStart. <<<<< 3 year long
SSP_D_Ld4.f09_g17.I1850Clm50BgcCrop.cheyenne_intel.clm-ciso_rtmColdSSP
ERS_D_Ld7_Mmpi-serial.1x1_smallvilleIA.IHistClm50BgcCropRs.cheyenne_intel.clm-decStart1851_noinitial

ekluzek · 2021-10-08T02:44:22Z

Also note that the change for GSSHA and GSSUN I thought would apply all the time, seems to only apply part of the time. As such I don't see a change for those two history variables in many cases.

ekluzek added 10 commits September 20, 2021 16:22

Fix ESCOMP#1462 so that GSSHA and GSSUN are actually set for history …

c3aea99

…files with values not just identical to missing value

Remove local version of max_cs so that the global one will be used fi…

ebcd92d

…xing ESCOMP#1394

Change initialization of this%t_soisno_col(c,1:nlevgrnd) from 274 to …

b02907c

…272 to avoid deep soil caron in permafrost regions fixing ESCOMP#1460

Change defaults for use_lch4 and use_nitrif_denitrif to be false if s…

1e2729f

…oil_decomp_method is None, and otherwise TRUE which means it will normally be true when FATES is on fixing ESCOMP#1465

allow methane to be on for dynamic lake test, this is addressed in ES…

dbc8066

…COMP#43, we currently just allow it to be true even through the conservation check for methane fails at the first time step of each year

Make Medlyn2011 the default for both clm5_0 and clm5_1 physics regard…

16187e9

…less if PHS is on or off

Add a sp no-anthro test that fails (because of ESCOMP#1496)

536c6e5

Increase compare tests

688494b

Fix ESCOMP#1496 so SP and no-anthro works

f1e9f8b

For fsurdat search for irrigated crop files first and if not found se…

a79e840

…arch for an exact match, this allows non irrigated to always be an option so the test for it can be removed

ekluzek self-assigned this Sep 23, 2021

ekluzek added 5 commits September 23, 2021 17:05

Update paramfile with ceta as per Van Kampenhour et al. 2017

96d6865

Need to add check on vichydro for fsurdat this fixe ESCOMP#1503

20d8a26

Lengthen wallclock for test

1ebd96c

Add specital logic for handling flanduse.timeseries in clm_demand try…

9d7a450

…ing first for nofail with crop and irrigation true, and if didn't find it try again with the exact match

Correct flanduse_timeseries name and set use_vichydro to true for the…

1448fbf

… SP datasets, while setting it to false for the crop datasets for landuse timeseries

ekluzek added the enhancement new capability or improved behavior of existing capability label Sep 30, 2021

ekluzek added 2 commits October 5, 2021 20:50

Add a failing test that to check that crop and FATES can't be on toge…

4756060

…ther

Make sure FATES does not run with crop on, when finding fsurdat for F…

1dc07fc

…ATES don't check for crop datasets first, add non vichydro datasets (pointing to the same file) for fsurdat and flanduse_timeseries so that FATES can use those datasets

ekluzek added 3 commits October 7, 2021 15:57

Initial update of change files

5bb554e

Finish changelog file

1ab1bc0

Update date

5b4bfeb

More update on changelog

12f8b82

ekluzek merged commit 09ef76b into ESCOMP:master Oct 8, 2021

ekluzek deleted the misc_PPE_answer_changes branch October 8, 2021 02:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Miscellaneous small answer changes#1497

Miscellaneous small answer changes#1497
ekluzek merged 21 commits into
ESCOMP:masterfrom
ekluzek:misc_PPE_answer_changes

ekluzek commented Sep 23, 2021 •

edited

Loading

Uh oh!

ekluzek commented Sep 30, 2021

Uh oh!

ekluzek commented Oct 6, 2021

Uh oh!

ekluzek commented Oct 7, 2021

Uh oh!

ekluzek commented Oct 8, 2021

Uh oh!

ekluzek commented Oct 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

ekluzek commented Sep 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Specific notes

Uh oh!

ekluzek commented Sep 30, 2021

Uh oh!

ekluzek commented Oct 6, 2021

Uh oh!

ekluzek commented Oct 7, 2021

Uh oh!

ekluzek commented Oct 8, 2021

Uh oh!

ekluzek commented Oct 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ekluzek commented Sep 23, 2021 •

edited

Loading